Re: [Xen-devel] [PATCH v5 03/22] arm/acpi: Add __acpi_map_table function for ARM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.02.16 at 15:12, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Fri, 26 Feb 2016, Shannon Zhao wrote:
>> --- a/xen/include/asm-arm/config.h
>> +++ b/xen/include/asm-arm/config.h
>> @@ -180,6 +180,8 @@
>>  #define FIXMAP_GICC1    4  /* Interrupt controller: CPU registers (first 
>> page) */
>>  #define FIXMAP_GICC2    5  /* Interrupt controller: CPU registers (second 
>> page) */
>>  #define FIXMAP_GICH     6  /* Interrupt controller: virtual interface 
>> control registers */
>> +#define FIX_ACPI_BEGIN  7  /* Start mappings of ACPI tables */
>> +#define FIX_ACPI_END    10 /* End mappings of ACPI tables */
>>  
>>  #define PAGE_SHIFT              12
> 
> Please rename FIX_ACPI_BEGIN and FIX_ACPI_END to FIXMAP_ACPI_BEGIN and
> FIXMAP_ACPI_END.
> 
> Also please move the declaration of FIX_ACPI_PAGES from asm-x86/acpi.h
> to a common header, and maybe rename it to NUM_ACPI_PAGES. Then you can
> define FIXMAP_ACPI_END as (FIXMAP_ACPI_BEGIN + NUM_ACPI_PAGES - 1).

That's a bad name, as it eliminates the connection to the fixmap.
If you really can't live with its current name, then please
NUM_FIXMAP_ACPI_PAGES or some such.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel