Re: [Xen-devel] Xen 4.4, xenstored and WATCH requests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

(CC'ing Linux maintainers)

OK. Thanks for all the information.

This seems to be a bug in Linux xenbus driver.

Relevant code snippet in
drivers/xen/xenbus/xenbus_dev_frontend.c:xenbus_write_watch()


  /* Success.  Synthesize a reply to say all is OK. */
  {
          struct {
                  struct xsd_sockmsg hdr;
                  char body[3];
          } __packed reply = {
                  {
                          .type = msg_type,
                          .len = sizeof(reply.body)
                  },
                  "OK"
          };
  
          mutex_lock(&u->reply_mutex);
          rc = queue_reply(&u->read_buffers, &reply, sizeof(reply));
          wake_up(&u->read_waitq);
          mutex_unlock(&u->reply_mutex);
  }

The synthesised reply doesn't echo the req_id back to user.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel