Re: [Xen-devel] [PATCH v10 07/31] docs/libxl: Introduce CHECKPOINT_CONTEXT to support migration v2 colo streams

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 22, 2016 at 10:52:11AM +0800, Wen Congyang wrote:
> It is the negotiation record for COLO.
> Primary->Secondary:
> control_id      0x00000000: Secondary VM is out of sync, start a new 
> checkpoint
> Secondary->Primary:
>                 0x00000001: Secondary VM is suspended
>                 0x00000002: Secondary VM is ready
>                 0x00000003: Secondary VM is resumed
> 
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> Signed-off-by: Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
> ---
>  docs/specs/libxl-migration-stream.pandoc | 25 +++++++++++++++++++++++--
>  tools/libxl/libxl_sr_stream_format.h     | 11 +++++++++++
>  tools/python/xen/migration/libxl.py      |  9 +++++++++
>  3 files changed, 43 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/specs/libxl-migration-stream.pandoc 
> b/docs/specs/libxl-migration-stream.pandoc
> index 2c97d86..5166d66 100644
> --- a/docs/specs/libxl-migration-stream.pandoc
> +++ b/docs/specs/libxl-migration-stream.pandoc
> @@ -1,6 +1,6 @@
>  % LibXenLight Domain Image Format
>  % Andrew Cooper <<andrew.cooper3@xxxxxxxxxx>>

You can add yours and Hongyang's name and email here as well.

> -% Revision 1
> +% Revision 2
>  
>  Introduction
>  ============
> @@ -119,7 +119,9 @@ type         0x00000000: END
>  
>               0x00000004: CHECKPOINT_END
>  
> -             0x00000005 - 0x7FFFFFFF: Reserved for future _mandatory_
> +             0x00000005: CHECKPOINT_STATE
> +
> +             0x00000006 - 0x7FFFFFFF: Reserved for future _mandatory_
>               records.
>  
>               0x80000000 - 0xFFFFFFFF: Reserved for future _optional_
> @@ -249,6 +251,25 @@ A checkpoint end record marks the end of a checkpoint in 
> the image.
>  The end record contains no fields; its body_length is 0.
>  
>  
> +CHECKPOINT\_STATE
> +--------------
> +
> +A checkpoint state record contains the control information for checkpoint.
> +
> +     0     1     2     3     4     5     6     7 octet
> +    +------------------------+------------------------+
> +    | control_id             | padding                |
> +    +------------------------+------------------------+
> +
> +--------------------------------------------------------------------
> +Field            Description
> +------------     ---------------------------------------------------
> +control_id       0x00000000: Secondary VM is out of sync, start a new 
> checkpoint
> +                 0x00000001: Secondary VM is suspended
> +                 0x00000002: Secondary VM is ready
> +                 0x00000003: Secondary VM is resumed

You commit message seems to suggest 0 can only go from primary to
secondary, while the other three only go from secondary to primary. You
probably need to spell out the direction here (and later enforce this
behaviour in code).

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel