Re: [Xen-devel] [PATCH 4/9] xl: Improve return and exit codes of main_console(), main_vncviewer() and main_dump_core().

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote:
> Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>
>
"console, vnc and core dump related function"

I'm not sure I'd put main_dump_core() in this patch, rather than in
patch 8, but I think it's just fine wither way.

> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> 
> @@ -3457,8 +3457,8 @@ int main_vncviewer(int argc, char **argv)
>      domid = find_domain(argv[optind]);
>  
>      if (vncviewer(domid, autopass))
> -        return 1;
> -    return 0;
> +        return EXIT_FAILURE;
> +    return EXIT_SUCCESS;
>
Have a look at vncviewer() and autoconnect_vncviewer() too.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel