Re: [Xen-devel] [PATCH v2 7/8] xen/x86: Use 2M superpages for text/data/bss mappings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.16 at 17:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> This balloons the size of Xen in memory from 4.4MB to 8MB, because of the
> required alignment adjustments.

Interesting - on v1 it was 12Mb iirc, and aiui you folded just one
pair of 2M pages, which would yield 10M now; did you perhaps
not account for .text spanning 2 large pages, due to the 1M bias
it starts at? But anyway...

> --- a/xen/include/xen/kernel.h
> +++ b/xen/include/xen/kernel.h
> @@ -65,6 +65,13 @@
>       1;                                      \
>  })
>  
> +#ifdef CONFIG_X86
> +extern const char __2M_text_start[], __2M_text_end[];
> +extern const char __2M_rodata_start[], __2M_rodata_end[];
> +extern char __2M_init_start[], __2M_init_end[];
> +extern char __2M_rwdata_start[], __2M_rwdata_end[];
> +#endif

I think this would better go into an x86-specific header. After all
there's no point for this patch to touch anything that's not x86-
specific anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel