Re: [Xen-devel] [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2016-02-22 at 17:29 +0800, Fu Wei wrote:
> Hi Julien,
> 
> On 20 February 2016 at 00:28, Julien Grall <julien.grall@xxxxxxxxxx>
> wrote:
> > Xen is currently crashing because of malformed compatible property for
> > the boot module. This is because the property string is not
> > null-terminated as requested by the ePAR spec.
> > ---
> > Âgrub-core/loader/arm64/xen_boot.c | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-
> > core/loader/arm64/xen_boot.c
> > index a914eb8..8ae43d7 100644
> > --- a/grub-core/loader/arm64/xen_boot.c
> > +++ b/grub-core/loader/arm64/xen_boot.c
> > @@ -156,7 +156,7 @@ prepare_xen_module_params (struct xen_boot_binary
> > *module, void *xen_boot_fdt)
> > ÂÂÂÂÂÂÂgrub_fdt_add_subnode (xen_boot_fdt, chosen_node, module_name);
> > 
> > ÂÂÂretval = grub_fdt_set_prop (xen_boot_fdt, module_node, "compatible",
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂMODULE_CUSTOM_COMPATIBLE,
> > sizeof(MODULE_CUSTOM_COMPATIBLE) - 1);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂMODULE_CUSTOM_COMPATIBLE,
> > sizeof(MODULE_CUSTOM_COMPATIBLE));
> > ÂÂÂif (retval)
> > ÂÂÂÂÂreturn grub_error (GRUB_ERR_IO, "failed to update FDT");
> > 
> > --
> > 1.9.1
> 
> I have tested it. yes, xen will crash without this patch.
> Tested-by: Fu Wei <fu.wei@xxxxxxxxxx>
> 
> BTW, since Vladimir has simplified the xen boot code , and Now Xen
> distinguishes modules by order.
> ------
> menuentry 'Foundation Model Xen test with initramfs' {
> ÂÂÂÂxen_hypervisor /xen -- no-bootscrub console=dtuart conswitch=x
> dtuart=serial0 dom0_mem=512M dom0_max_vcpus=2
> ÂÂÂÂxen_module /dom0_kernel_Image console=hvc0 root=/dev/ram0 ro
> ÂÂÂÂxen_module /dom0_initramfs.cpio
> ÂÂÂÂxen_module /xsm
> ÂÂÂÂdevicetree /fvp-base-gicv2-psci.dtb
> }
> -----
> 
> Maybe we should update doc toÂÂcoordinate with this change.
> 
> And another problem is: How does XEN identify XSM?
> Test with the config file above, I got "(XEN) MODULE[3]:
> 00000008fabb4000 - 00000008fabb65e7 Unknown"

I must confess when Vlad proposed this change I thought Xen was able to
automatically probe for whether a module was an XSM module. Perhaps it is
either broken or that functionality never existed to start with?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel