Re: [Xen-devel] [PATCH v2 3/4] m4/python: fix checks for Python library support

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 2/22/16 10:22 AM, Ian Jackson wrote:
> Doug Goldstein writes ("[PATCH v2 3/4] m4/python: fix checks for Python 
> library support"):
>> AC_CHECK_LIB() was running gcc -Llib -lm -lutils conftest.c which on
>> platforms that do as needed operations by default will result in
>> underlinking. Instead AC_CHECK_LIB() suggests supplying the extra
>> libraries necessary in a 5th argument.
> 
> I'm afraid I don't quite follow why the code in the patch has the
> effect you desire.  Why does setting LDFLAGS not work ?  Forgive me if
> I'm being dense - I'm afraid I have a cold.
> 
> Regards,
> Ian.
> 

In fact this pattern is repeated all over the code base in makefiles:

libxenctrl.so.$(MAJOR).$(MINOR): $(CTRL_PIC_OBJS)
    $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG)
-Wl,libxenctrl.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^
$(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab)
$(LDLIBS_libxengntshr) $(LDLIBS_libxencall)
$(LDLIBS_libxenforeignmemory) $(PTHREAD_LIBS) $(APPEND_LDFLAGS)


COMPILER CFLAGS/LDFLAGS -o TARGET SOURCE LIBS


-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel