Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 02/22/2016 05:27 AM, Borislav Petkov wrote:
> On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote:
> > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
> > index 1ae89a2721d6..fe0d579b63e3 100644
> > --- a/arch/x86/include/asm/x86_init.h
> > +++ b/arch/x86/include/asm/x86_init.h
> > @@ -84,11 +84,14 @@ struct x86_init_paging {
> >    *                            boot cpu
> >    * @timer_init:                       initialize the platform timer (default 
> > PIT/HPET)
> >    * @wallclock_init:           init the wallclock device
> > + * @no_cmos_rtc:               set when platform has no CMOS real-time clock
> > + *                             present
> >    */
> >   struct x86_init_timers {
> >         void (*setup_percpu_clockev)(void);
> >         void (*timer_init)(void);
> >         void (*wallclock_init)(void);
> > +       bool no_cmos_rtc;
> I'd add
>
>         u64 flags;
>
> to x86_init_ops and then set X86_PLATFORM_NO_RTC or so in there. The
> reason being, others could use that flags field too, for other stuff and
> define more bits.
Maybe timer_flags or platform_flags (or something else) to be a little 
more cscope-friendly?
-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel