Re: [Xen-devel] [PATCH] version: Document guest_handle

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.02.16 at 15:32, <konrad@xxxxxxxxxx> wrote:
> --- a/xen/include/public/version.h
> +++ b/xen/include/public/version.h
> @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
>  #define XENVER_pagesize 7
>  
>  /* arg == xen_domain_handle_t. */
> +/*
> + * The toolstack fills it out for the guest consumption. Usually it is
> + * the UUID of the guest but can be anything.
> + */
>  #define XENVER_guest_handle 8

Generally fine, but I'm not overly happy with the wording. I'd
prefer if it was made slightly less vague this is meant to be the
UUID. Maybe "The toolstack fills it out for guest consumption. It
is intended to hold the UUID of the guest"?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel