Re: [Xen-devel] [PATCHv1 1/5] domctl: Add op to get/set generic numeric parameters

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.02.16 at 19:52, <david.vrabel@xxxxxxxxxx> wrote:
> ---
>  xen/arch/x86/domctl.c       | 14 ++++++++++++++

What about ARM?

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1092,6 +1092,25 @@ struct xen_domctl_psr_cat_op {
>  typedef struct xen_domctl_psr_cat_op xen_domctl_psr_cat_op_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_domctl_psr_cat_op_t);
>  
> +/*
> + * Get/set a per-domain numeric parameter.
> + *
> + * If bit 31 of @param is set, the original value is returned and the
> + * new value is written.  If bit 31 is clear, the value is returned.
> + *
> + * Not all parameters are valid for all architectures or domain types.
> + */
> +#define XEN_DOMCTL_PARAM_SET (1u << 31)
> +
> +struct xen_domctl_param {
> +    /* IN */
> +    uint32_t param;
> +    /* IN/OUT */
> +    uint64_t value;

This needs to be uint64_aligned_t, and I wonder whether using
the padding field wouldn't be the more natural way for conveying
get/set intentions.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel