Re: [Xen-devel] [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-02-19 at 10:50 +0000, Andrew Cooper wrote:
> On 19/02/16 10:40, Wei Liu wrote:
> > On Thu, Feb 18, 2016 at 10:10:09PM +0000, Andrew Cooper wrote:
> > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > > ---
> > > CC: Jan Beulich <JBeulich@xxxxxxxx>
> > > CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> > > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > CC: Doug Goldstein <cardoe@xxxxxxxxxx>
> > > ---
> > > Âtools/firmware/hvmloader/xenbus.c | 2 +-
> > > Â1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/firmware/hvmloader/xenbus.c
> > > b/tools/firmware/hvmloader/xenbus.c
> > > index d0ed993..947d865 100644
> > > --- a/tools/firmware/hvmloader/xenbus.c
> > > +++ b/tools/firmware/hvmloader/xenbus.c
> > > @@ -27,7 +27,7 @@
> > > Â
> > > Â#include "util.h"
> > > Â#include "hypercall.h"
> > > -#include <errno.h>
> > > +#include <xen/errno.h>
> > This doesn't seem to compile for me. Xen's error numbers live in a
> > different name space.
> 
> It compiled fine for me.ÂÂHVMLoader should use __XEN_TOOLS__.

It shouldn't and doesn't, seeÂ3237645813d7 which stopped setting
__XEN_TOOLS__ globally for all of tools/* and consequently removed the
-U__XEN_TOOLS__ from hvmloader.

In any case I don't think __XEN_TOOLS__ has any impact on xen/errno.h
(which is, perhaps confusingly, xen/include/public/errno.h and not
xen/include/xen/errno.h)

For normal userspace uses of __XEN_TOOLS__ you wouldn't want unprefixed Xen
errno values added to your namespace anyway -- since you need to deal with
OS errno names/values.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel