Re: [Xen-devel] [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-02-19 at 10:40 +0000, Wei Liu wrote:
> On Thu, Feb 18, 2016 at 10:10:09PM +0000, Andrew Cooper wrote:
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> > CC: Jan Beulich <JBeulich@xxxxxxxx>
> > CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > CC: Doug Goldstein <cardoe@xxxxxxxxxx>
> > ---
> > Âtools/firmware/hvmloader/xenbus.c | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/firmware/hvmloader/xenbus.c
> > b/tools/firmware/hvmloader/xenbus.c
> > index d0ed993..947d865 100644
> > --- a/tools/firmware/hvmloader/xenbus.c
> > +++ b/tools/firmware/hvmloader/xenbus.c
> > @@ -27,7 +27,7 @@
> > Â
> > Â#include "util.h"
> > Â#include "hypercall.h"
> > -#include <errno.h>
> > +#include <xen/errno.h>
> 
> This doesn't seem to compile for me. Xen's error numbers live in a
> different name space.

Indeed.

Either all the codes in hvmloader would need updating or it needs to play
the same trick as xen/include/xen/errno.h.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel