Re: [Xen-devel] [PATCH v2 15/16] xenalyze: handle RTDS scheduler events

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2016-02-18 at 17:06 +0000, George Dunlap wrote:
> On 18/02/16 17:02, Dario Faggioli wrote:
> > On Thu, 2016-02-18 at 15:28 +0000, George Dunlap wrote:
> > >Â
> > > > +ÂÂÂÂÂÂÂÂcase TRC_SCHED_CLASS_EVT(RTDS, 2): /*
> > > > RUNQ_PICKÂÂÂÂÂÂÂÂ*/
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂif(opt.dump_all) {
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂstruct {
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned int vcpuid:16, domid:16;
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned int cur_dl_lo, cur_dl_hi;
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned int cur_bg_lo, cur_bg_hi;
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ} *r = (typeof(r))ri->d;
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuint64_t dl = (((uint64_t)r->cur_dl_hi) << 32)
> > > > +
> > > > r->cur_dl_lo;
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuint64_t bg = (((uint64_t)r->cur_bg_hi) << 32)
> > > > +
> > > > r->cur_bg_lo;
> > > 
> > > Why are you doing this, instead of just using uint64_t?
> > > 
> > It was to make the struct in sched_rt.c and here exactly match, for
> > ease of someone reading both the pieces of code at the same time,
> > to
> > understand what's being printed.
> > 
> > However, yes, using uint64_t is probably equally understandable,
> > and
> > more readable in case one only look at this code, so I can change
> > this
> > (and resend).
> 
> Hrm, well perhaps having the struct match exactly is better.
> 
> I think most of these patches can be checked in now.ÂÂWhat about
> checking in the other patches, then sending a follow-up series with
> the
> struct changed in the scheduler, and then this patch with the
> resulting
> changes?
> 
This would work for me.

Regards,
Dario
--Â
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel