Re: [Xen-devel] [RFC PATCH 4/7] common/pv-iommu: Add query, map and unmap ops

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >  ret_t do_iommu_op(XEN_GUEST_HANDLE_PARAM(void) arg, unsigned int count)
> 
> Shouldn't this be changed to be pv_iommu_op_t? instead of void?
> 
> 
> >  {
> > -    return -ENOSYS;
> > +    ret_t ret = 0;
> > +    int i;
> 
> unsigned int ?
> > +    struct pv_iommu_op op;
> > +    struct domain *d = current->domain;
> > +
> > +    if ( !is_hardware_domain(d) )
> > +        return -ENOSYS;
> 
> -EPERM ?
> 
> > +


Also you are missing the XSM checks which should be here.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel