Re: [Xen-devel] [PATCH v5 2/7] VT-d: Check VT-d Device-TLB flush error(MMU part).

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.02.16 at 11:18, <quan.xu@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/acpi/power.c
> +++ b/xen/arch/x86/acpi/power.c
> @@ -45,6 +45,8 @@ void do_suspend_lowlevel(void);
>  
>  static int device_power_down(void)
>  {
> +    int rc;
> +
>      console_suspend();
>  
>      time_suspend();
> @@ -53,7 +55,9 @@ static int device_power_down(void)
>  
>      ioapic_suspend();
>  
> -    iommu_suspend();
> +    rc = iommu_suspend();
> +    if ( rc )
> +        return rc;

I'm not going to look at the rest of this patch, seeing that the v4
comment[1] regarding the issue here was left un-addressed.

Jan

[1] http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01555.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel