Re: [Xen-devel] [PATCH v2 05/30] xen/public: Export cpu featureset information in the public API

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/02/16 16:27, Jan Beulich wrote:
>>>> On 05.02.16 at 14:41, <andrew.cooper3@xxxxxxxxxx> wrote:
>> +/* Intel-defined CPU features, CPUID level 0x00000001.edx, word 0 */
>> +#define X86_FEATURE_FPU           ( 0*32+ 0) /*   Onboard FPU */
> Regardless of you limiting the interface to tools only, I'm not
> convinced exposing constants starting with X86_* here is
> appropriate.

The toolstack already uses these exact names.  Patch 25 depends on me
not changing any of these.

>
>> +#define X86_FEATURE_XMM           ( 0*32+25) /*   Streaming SIMD Extensions 
>> */
>> +#define X86_FEATURE_XMM2          ( 0*32+26) /*   Streaming SIMD 
>> Extensions-2 */
>> [...]
>> +/* Intel-defined CPU features, CPUID level 0x00000001.ecx, word 1 */
>> +#define X86_FEATURE_XMM3          ( 1*32+ 0) /*   Streaming SIMD 
>> Extensions-3 */
> Apart from that exposing them should be done using canonical instead
> of Linux-invented names, i.e. s/XMM/SSE/ for the above lines. I've
> had a need to create a patch to do this just earlier today.

I can do this as a preparatory patch.  Any other names you want to me to
change?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel