Re: [Xen-devel] [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2016-02-17 at 10:05 +0000, Ian Campbell wrote:
> On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote:
> > When dequoting config strings in xlu__cfgl_dequote(), unknown
> > characters following a '\', and the '\' itself, are discarded.
> > E.g. a disk configuration string containing
> > 
> > Â rbd:pool/image:mon_host=192.168.0.100\:6789
> > 
> > would be dequoted as
> > 
> > Â rbd:pool/image:mon_host=192.168.0.1006789
> > 
> > Instead of discarding the '\' and unknown character, reject the
> > string and set error to EINVAL.
> 
> Missing your S-o-b.
> 
> Other than that:
> 
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂxlu__cfgl_lexicalerror(ctx, "invalid character after
> > backlash "
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ"in quoted string");
> 
> Please try where possible not to split string constants (so log messages
> can more easily be grepped for).

I see now that this parsing code is pretty liberally ignoring this advice
already. So apart from the missing S-o-b this patch is

    Acked-by: Ian Campbell <    ian.campbell@xxxxxxxxxx    >

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel