Re: [Xen-devel] [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events

[Meng Xu <xumengpanda@xxxxxxxxx>]

Hi Dario,

Since this patch did some obvious change, I will reply with
reviewed-by, although my reviewed-by does not count much. ;-)

On Tue, Feb 16, 2016 at 1:11 PM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
>
> it is enabled for pretty much all of them already.
> There were just a few that had it disabled.
>
> When tracing a scheduler, timing information is
> really important, so enable it everywhere scheduling
> related.
>
> Note that this was not really a problem if looking
> at the traces with xenalyze, but it was if using
> xentrace_format.

I just have a quick (and perhaps naive) question: :-)
If xenanlyze works better than xentrace_format, why shouldn't we stick
to xenanlyze?
Is there some functionality xentrace_format can but xenalyze cannot?

(I have to confess that I only used xenalyze but didn't use
xentrace_format before. :-()

>
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
> Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
> Cc: Meng Xu <xumengpanda@xxxxxxxxx>
> Cc: Tianyang Chen <tiche@xxxxxxxxxxxxxx>
> Cc: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  xen/common/sched_credit.c  |    2 +-
>  xen/common/sched_credit2.c |    6 +++---
>  xen/common/sched_rt.c      |    2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> index 5279b92..bd2f37f 100644
> --- a/xen/common/sched_credit.c
> +++ b/xen/common/sched_credit.c
> @@ -476,7 +476,7 @@ static inline void __runq_tickle(struct csched_vcpu *new)
>          {
>              /* Avoid TRACE_*: saves checking !tb_init_done each step */
>              for_each_cpu(cpu, &mask)
> -                __trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu);
> +                __trace_var(TRC_CSCHED_TICKLE, 1, sizeof(cpu), &cpu);
>          }
>
>          /* Send scheduler interrupts to designated CPUs */
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index cf40f68..2934e26 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -456,7 +456,7 @@ runq_insert(const struct scheduler *ops, unsigned int 
> cpu, struct csched2_vcpu *
>          d.dom = svc->vcpu->domain->domain_id;
>          d.vcpu = svc->vcpu->vcpu_id;
>          d.pos = pos;
> -        trace_var(TRC_CSCHED2_RUNQ_POS, 0,
> +        trace_var(TRC_CSCHED2_RUNQ_POS, 1,
>                    sizeof(d),
>                    (unsigned char *)&d);
>      }
> @@ -564,7 +564,7 @@ tickle:
>              unsigned cpu:16, pad:16;
>          } d;
>          d.cpu = ipid; d.pad = 0;
> -        trace_var(TRC_CSCHED2_TICKLE, 0,
> +        trace_var(TRC_CSCHED2_TICKLE, 1,
>                    sizeof(d),
>                    (unsigned char *)&d);
>      }
> @@ -1721,7 +1721,7 @@ csched2_schedule(
>       */
>      if ( tasklet_work_scheduled )
>      {
> -        trace_var(TRC_CSCHED2_SCHED_TASKLET, 0, 0,  NULL);
> +        trace_var(TRC_CSCHED2_SCHED_TASKLET, 1, 0,  NULL);
>          snext = CSCHED2_VCPU(idle_vcpu[cpu]);
>      }
>      else
> diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
> index 53de6d6..33ac9de 100644
> --- a/xen/common/sched_rt.c
> +++ b/xen/common/sched_rt.c
> @@ -985,7 +985,7 @@ out:
>          } d;
>          d.cpu = cpu_to_tickle;
>          d.pad = 0;
> -        trace_var(TRC_RTDS_TICKLE, 0,
> +        trace_var(TRC_RTDS_TICKLE, 1,
>                    sizeof(d),
>                    (unsigned char *)&d);
>      }
>

Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>

Best,

Meng


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel