Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.02.16 at 16:15, <george.dunlap@xxxxxxxxxx> wrote:
> What about something like this instead?  (Ported to be on top of this
> patch, since it's already been committed.)
> 
>  -George
> 
> [PATCH] xen/p2m: Make dump table printing less clever
> 
> Rather than detecting whether to print out the numerical value of the
> memory type based on whether
> the second byte of the stringified value is a null character, just
> always print out both.

Generally a good idea, but ...

> @@ -1262,14 +1262,13 @@ static void ept_dump_p2m_table(unsigned char key)
>                  if ( ept_entry->sa_p2mt == p2m_populate_on_demand )
>                      printk("gfn: %13lx order: %2d PoD\n", gfn, order);
>                  else
> -                    printk("gfn: %13lx order: %2d mfn: %13lx %c%c%c%c%c%c\n",
> +                    printk("gfn: %13lx order: %2d mfn: %13lx 
> %c%c%c%s(%d)%c\n",
>                             gfn, order, ept_entry->mfn + 0UL,
>                             ept_entry->r ? 'r' : ' ',
>                             ept_entry->w ? 'w' : ' ',
>                             ept_entry->x ? 'x' : ' ',
> -                           memory_type_to_str(ept_entry->emt)[0],
> -                           memory_type_to_str(ept_entry->emt)[1]
> -                           ?: ept_entry->emt + '0',
> +                           memory_type_to_str(ept_entry->emt),
> +                           ept_entry->emt,
>                             c ?: ept_entry->ipat ? '!' : ' ');

... this will further increase the amount of data to be pushed out,
and the debug key being handled here is already putting quite a
bit of load on the serial console. It was the goal to save every byte
we can which drove me to the solution currently in place.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel