Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/02/16 16:00, Konrad Rzeszutek Wilk wrote:
> Hey,
>
> I wanted to ask what folks would think of expanding the Wiki to include 
> (making it a diff
> for simpler) this change. With my giant 30 set of patches that not only CC-ed
> xen-devel twice but had some patches CC some maintainers but not others - I 
> figured
> it may be good to describe this in the Wiki:
>
> --- orig      2016-02-15 10:45:27.719204371 -0500
> +++ new       2016-02-15 10:58:33.113755665 -0500
> @@ -140,7 +140,35 @@
>  * The maintainers are listed in the MAINTAINERS file at the top of the Xen 
> source tree. If no maintainer is listed then there is no need for a CC (if 
> you are modifying code with no maintainer then you might like to consider 
> becoming the maintainer for that piece of code!).
>  ** You can pipe your patch to the <code>./scripts/get_maintainer.pl</code> 
> tool and it will list the relevant maintainers.
>  * In addition to CCing the maintainer you should always send patches to (via 
> TO) the xen-devel@xxxxxxxxxxxxxxxxxxxx mailing list as well.
> -* To add a CC when sending the mail you can use the ''--cc'' option to the 
> ''git send-email'' command, or you can do it manually in your MUA.
> +* To add a CC when sending the mail you can:
> +  * use the ''--cc'' option to the ''git send-email'' command - however if 
> your
> +    patchset is to multiple maintainers - you may end up sending all of the
> +    patches to all maintainers  - where some of them have no interest in
> +    viewing them (as they are not under their responsibility).
> +  * edit each patch to have the proper maintainer on the CC list by adding:
> +<pre>
> +CC: joe@xxxxxxx

andrewcoop@andrewcoop:/local/xen.git/xen$ dig -t ANY doe.com
...
;; AUTHORITY SECTION:
doe.com.        3600    IN    NS    ns52.domaincontrol.com.
doe.com.        3600    IN    NS    ns51.domaincontrol.com.

;; ADDITIONAL SECTION:
ns51.domaincontrol.com.    73514    IN    A    216.69.185.26
ns51.domaincontrol.com.    56142    IN    AAAA    2607:f208:206::1a

I would use example.com instead.

Otherwise, looks good to me.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel