Re: [Xen-devel] [PATCH V3] vm_event: Remove xc_mem_access_enable_emulate() and friends

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Feb 14, 2016 at 10:38:58AM +0200, Razvan Cojocaru wrote:
> xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate()
> are currently no-ops, that is all they do is set a flag that
> nobody else checks. The user can already set the EMULATE flags in
> the vm_event response if emulation is desired, and having an extra
> check above that is not inherently safer, but it does complicate
> (currenly unnecessarily) the API. This patch removes these
> functions and the corresponding hypervisor code.
> 
> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> 
> ---
> Changes since V1:
>  - Commented-out the XENMEM_access_op_enable_emulate and
>    XENMEM_access_op_disable_emulate #defines instead of simply
>    removing them to prevent their reuse, as requested by
>    Jan Beulich.
> ---
>  tools/libxc/include/xenctrl.h | 11 -----------
>  tools/libxc/xc_mem_access.c   | 24 ------------------------

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel