Re: [Xen-devel] Two linkers - EFI one (mingw64) and normal GNU one [Fedora]

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On February 12, 2016 5:17:42 PM EST, Doug Goldstein <cardoe@xxxxxxxxxx> wrote:
>On 2/12/16 11:19 AM, Konrad Rzeszutek Wilk wrote:
>> Hey,
>> 
>> Fedora for the longest time seems to have two linkers - one normal
>for GNU
>> applications and then another - mingw64 - for building EFI
>applications.
>> 
>> Which means that to compile ELF binaries on Fedora requires this
>patch
>> (taken from Fedora build):
>> 
>> From 078f2d6155e940a91c1f668b86dcb9534d76b8b7 Mon Sep 17 00:00:00
>2001
>> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> Date: Wed, 6 Jan 2016 16:39:23 -0500
>> Subject: [PATCH] EFI build using mingw
>> 
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> 
>> Conflicts:
>>      xen/arch/x86/Makefile
>> ---
>>  xen/Makefile              | 2 ++
>>  xen/arch/x86/Makefile     | 6 +++---
>>  xen/arch/x86/efi/Makefile | 2 +-
>>  3 files changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/xen/Makefile b/xen/Makefile
>> index f702525..09c708c 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -20,6 +20,8 @@ export XEN_ROOT := $(BASEDIR)/..
>>  MAKEFLAGS += -rR
>>  
>>  EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi
>> +LD_EFI ?= $(LD)
>
>So I think doing this is reasonable to allow Fedora to override it. You
>can even do a check that LD_EFI supports i386pep as a target and skip
>doing the EFI build/install if it does not. Similar to the case when
>EFI_VENDOR is not set.
>
>I don't see what adding a configure.ac would buy you since you would
>have to hardcode a number of different paths to check for a linker that
>works because the path that Fedora uses is different from every other
>distro I currently have access to.

OK, which is why I was thinking of configure.ac trying different paths.

>
>The real question is why can't we change the EFI stub generation to be
>closer to how Linux does it which doesn't have this same constraint.

That is what Daniel suggested going forward.

 But that is a bit of further material.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel