Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.02.16 at 01:22, <tlengyel@xxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/event.c
> +++ b/xen/arch/x86/hvm/event.c
> @@ -23,40 +23,9 @@
>  #include <asm/hvm/event.h>
>  #include <asm/monitor.h>
>  #include <asm/altp2m.h>
> +#include <asm/vm_event.h>
>  #include <public/vm_event.h>
>  
> -static void hvm_event_fill_regs(vm_event_request_t *req)
> -{
> -    const struct cpu_user_regs *regs = guest_cpu_user_regs();
> -    const struct vcpu *curr = current;
> -
> -    req->data.regs.x86.rax = regs->eax;
> -    req->data.regs.x86.rcx = regs->ecx;
> -    req->data.regs.x86.rdx = regs->edx;
> -    req->data.regs.x86.rbx = regs->ebx;
> -    req->data.regs.x86.rsp = regs->esp;
> -    req->data.regs.x86.rbp = regs->ebp;
> -    req->data.regs.x86.rsi = regs->esi;
> -    req->data.regs.x86.rdi = regs->edi;
> -
> -    req->data.regs.x86.r8  = regs->r8;
> -    req->data.regs.x86.r9  = regs->r9;
> -    req->data.regs.x86.r10 = regs->r10;
> -    req->data.regs.x86.r11 = regs->r11;
> -    req->data.regs.x86.r12 = regs->r12;
> -    req->data.regs.x86.r13 = regs->r13;
> -    req->data.regs.x86.r14 = regs->r14;
> -    req->data.regs.x86.r15 = regs->r15;
> -
> -    req->data.regs.x86.rflags = regs->eflags;
> -    req->data.regs.x86.rip    = regs->eip;
> -
> -    req->data.regs.x86.msr_efer = curr->arch.hvm_vcpu.guest_efer;
> -    req->data.regs.x86.cr0 = curr->arch.hvm_vcpu.guest_cr[0];
> -    req->data.regs.x86.cr3 = curr->arch.hvm_vcpu.guest_cr[3];
> -    req->data.regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
> -}

With this diff I suppose the patch here is meant to replace
"vm_event: Record FS_BASE/GS_BASE during events"? Such should
be made explicit, either by adding a note here (after the first ---
separator) or by explicitly withdrawing the other patch.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel