[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vm_event: Record FS_BASE/GS_BASE during events


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tamas K Lengyel <tlengyel@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Thu, 11 Feb 2016 22:13:57 +0200
  • Cc: Keir Fraser <keir@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Thu, 11 Feb 2016 20:14:10 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=PeooOXkqNxc6dsBXhcqy/Uurjd9iRkpgX36NeJSAKgJ2FQYmOJlJCgw+7t4krG4fOhM8ZRrHB8mNUX8rAoZk3Y9cilsXYilS58cYCI5EGepHDlcs8BgKFAcIijT9G+XRwti9ZNXhoQiiGtZh7ITtpywllPkNe2/oy8J82oxq3Rihtvt/aQfVdaJZVX4zHatJ8PJgFDRP6BKeUroihEmOwWp8gfHt3GS1n8mdpDMAf17a1uGXBshyc4q8lUtmHAjwsI358unuwMlnxIzLntDun40BGwhRiYHGzDsJpJlrSMunX+Jveux0b89RGhowHcsaL3YJsFzcBcXUXv0cqD38ag==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 02/11/2016 10:04 PM, Andrew Cooper wrote:
> On 11/02/16 20:00, Razvan Cojocaru wrote:
>> On 02/11/2016 09:55 PM, Andrew Cooper wrote:
>>> On 11/02/16 19:54, Razvan Cojocaru wrote:
>>>> On 02/11/2016 09:51 PM, Tamas K Lengyel wrote:
>>>>> While the public vm_event header specifies fs_base/gs_base as registers 
>>>>> that
>>>>> should be recorded for each event, that hasn't actually been the case. In
>>>>> this patch we remedy the issue.
>>>>>
>>>>> Signed-off-by: Tamas K Lengyel <tlengyel@xxxxxxxxxxx>
>>>>> Cc: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>>>> Cc: Keir Fraser <keir@xxxxxxx>
>>>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>>>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>>> ---
>>>>>  xen/arch/x86/hvm/event.c | 9 ++++++++-
>>>>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>>> Fair enough.
>>>>
>>>> Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>> Oops.
>>>
>>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> This has actually been intentional, in that we've only needed those
>> fields for EPT events, and thought that not filling what's not needed
>> until it's needed would save a tiny bit of hypervisor processing time.
>> They are being filled in only for page fault events at the moment.
>>
>> I believe it's been discussed at the time. We still don't need those
>> coming with the events that use hvm_event_fill_regs(), but if Tamas
>> needs them then by all means.
> 
> The public header file does suggest that all of vm_event_regs_x86 will
> be complete.  Are there any other fields currently missing?

There are. p2m_vm_event_fill_regs() fills everything in (in
xen/arch/x86/mm/p2m.c). hvm_event_fill_regs() still does not, even after
Tamas' patch.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.