Re: [Xen-devel] [PATCH 2/3] xen: sched: add wakeup flags to the scheduler interface

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2016-02-11 at 06:24 -0700, Jan Beulich wrote:
> > > > On 11.02.16 at 12:38, <dario.faggioli@xxxxxxxxxx> wrote:
> > --- a/xen/include/xen/sched-if.h
> > +++ b/xen/include/xen/sched-if.h
> > @@ -144,7 +144,8 @@ struct scheduler {
> > ÂÂÂÂÂvoidÂÂÂÂÂÂÂÂÂ(*remove_vcpu)ÂÂÂÂ(const struct scheduler *,
> > struct vcpu *);
> > Â
> > ÂÂÂÂÂvoidÂÂÂÂÂÂÂÂÂ(*sleep)ÂÂÂÂÂÂÂÂÂÂ(const struct scheduler *,
> > struct vcpu *);
> > -ÂÂÂÂvoidÂÂÂÂÂÂÂÂÂ(*wake)ÂÂÂÂÂÂÂÂÂÂÂ(const struct scheduler *,
> > struct vcpu *);
> > +ÂÂÂÂvoidÂÂÂÂÂÂÂÂÂ(*wake)ÂÂÂÂÂÂÂÂÂÂÂ(const struct scheduler *,
> > struct vcpu *,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned int);
> 
> Just one cosmetic comment: You properly use "unsigned int" here,
> but just "unsigned" everywhere else in this patch. May I ask that
> you use the canonical full form everywhere?
> 
Of course you can :-), and I was already down to change this... But, as
a matter of fact, this patch is not going to be present in v2.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel