Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.02.16 at 17:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/02/16 16:18, Jan Beulich wrote:
>>
>>> --- a/xen/include/asm-x86/hvm/event.h
>>> +++ b/xen/include/asm-x86/hvm/event.h
>>> @@ -17,6 +17,12 @@
>>>  #ifndef __ASM_X86_HVM_EVENT_H__
>>>  #define __ASM_X86_HVM_EVENT_H__
>>>  
>>> +enum hvm_event_breakpoint_type
>>> +{
>>> +    HVM_EVENT_SOFTWARE_BREAKPOINT,
>>> +    HVM_EVENT_SINGLESTEP_BREAKPOINT,
>>> +};
>> I don't see what good it does to put existing constants into an
>> enum.
> 
> An enum was requested during review of v1, because "bool
> software_breakpoint" isn't a good function interface.
> 
> I don't mind if #defines were used instead, but the parameter should
> have a semantic name used in calling code.

To calling code there's no difference whether the parameter is of
an enum type or just plain or unsigned int.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel