[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h





On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx> wrote:
Rename:
  - arch/x86/monitor_x86.c -> arch/x86/monitor.c
  - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h

(previous commit explains why these renames were necessary)

Referencing a "previous commit" like this is not acceptable as you don't know how these patches will get applied and there might be other patches that get committed in-between yours. In each patch explain clearly why the patch is needed. I still find it odd that you need to rename x86/monitor.c -> x86/monitor_x86.c -> x86/monitor.c in the same series.
Â

Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
---

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.