Re: [Xen-devel] [PATCH v2 2/2] build: convert xenoprof to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.02.16 at 05:15, <cardoe@xxxxxxxxxx> wrote:
> Convert the xenoprof x86 build time option to Kconfig.

First of all it's not clear to me whether this really was ever meant to
be a build time option. It's using := (not ?= ), and without there being
a clear indication that this was intended I'm inclined to assume this
is just the result of someone doing something in a, well, slightly
broken way. Nevertheless I can see the point of wanting to disable
this code, but I think that ...

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -84,6 +84,19 @@ config LATE_HWDOM
>  
>         If unsure, say N.
>  
> +# Adds support for Xenoprof
> +config XENOPROF
> +     bool "Xen Oprofile Support"
> +     default y
> +     depends on X86

... this should then also depend on EXPERT.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel