Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

[Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>]

On 2/9/2016 1:03 PM, Stefano Stabellini wrote:
> On Mon, 8 Feb 2016, Corneliu ZUZU wrote:
> > X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry,
> > also move arch/arm/hvm.c to arch/arm/hvm/hvm.c.
> Why are we doing this? These are not header files, their paths don't
> necessarily need to be the same and xen/arch/x86/hvm/hvm.c is very
> different from xen/arch/arm/hvm.c.
>
> Please state the reason more clearly.
>
>
> > Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
> > ---
> >   xen/arch/arm/Makefile     |  2 +-
> >   xen/arch/arm/hvm.c        | 67 -----------------------------------------------
> >   xen/arch/arm/hvm/Makefile |  1 +
> >   xen/arch/arm/hvm/hvm.c    | 66 ++++++++++++++++++++++++++++++++++++++++++++++
Because the ARM side hvm.c currently exists solely to add an implementation for
do_hvm_op, which on x86 is @ arch/x86/hvm/hvm.c. I presume the ARM hvm.c got 
its name
from the X86 file, so I thought a symmetry between the two was intended from 
the start.
Also, the hvm directory was created to separate hvm-specific code, which is the 
case w/
do_hvm_op on any arch.

Corneliu.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel