Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/02/16 17:12, Corneliu ZUZU wrote:
> On 2/8/2016 7:04 PM, Andrew Cooper wrote:
>> On 08/02/16 16:57, Corneliu ZUZU wrote:
>>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry,
>>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c.
>>>
>>> Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
>> For future reference, constructing your patches with -M (detect renames)
>> makes reviews of patches like this far easier.
>>
>> While you are editing this file, please put a local variable block on
>> the bottom of the file.  See the final section of CODING_STYLE in the
>> root.
>>
>> ~Andrew
>>
> I'm really sorry, I forgot, I was actually *counting* on that option,
> wanted to use it as -M40%
> actually. And I really don't get why git malformed the introductory
> message.
> Since the diffs would indeed look *much* better w/ the -M option and I
> should also add
> the variable block @ the end of that file (which was originally
> missing) would it be advised to
> resend this series?

I would wait for some other review first.  There are some useful
comments to be given even with the series like this.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel