Re: [Xen-devel] [PATCH v7 3/5] libxl: add support for vscsi

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Feb 05, Olaf Hering wrote:

> @@ -6799,6 +7375,8 @@ int libxl_retrieve_domain_configuration(libxl_ctx *ctx, 
> uint32_t domid,
>  
>      MERGE(nic, nics, COMPARE_DEVID, {});
>  
> +    MERGE(vscsictrl, vscsictrls, COMPARE_VSCSI, {});

I think the actual "merge" should be like this, to copy the data
gathered from xenstore into the d_config which was built from JSON.
{
libxl_device_vscsictrl_dispose(dst);
libxl_device_vscsictrl_copy(CTX, dst, src);
}

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel