Re: [Xen-devel] [PATCH v10 3/9] libxc: allow creating domains without emulated devices.

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Dec 07, Roger Pau Monne wrote:

> Introduce a new flag in xc_dom_image that turns on and off the emulated
> devices. This prevents creating the VGA hole, the hvm_info page and the
> ioreq server pages. libxl unconditionally sets it to true for all HVM
> domains at the moment.

> @@ -1428,8 +1434,9 @@ static int meminit_hvm(struct xc_dom_image *dom)
>       * Under 2MB mode, we allocate pages in batches of no more than 8MB to 
>       * ensure that we can be preempted and hence dom0 remains responsive.
>       */
> -    rc = xc_domain_populate_physmap_exact(
> -        xch, domid, 0xa0, 0, memflags, &dom->p2m_host[0x00]);
> +    if ( dom->device_model )
> +        rc = xc_domain_populate_physmap_exact(
> +            xch, domid, 0xa0, 0, memflags, &dom->p2m_host[0x00]);

I think this causes a build failure when building tools/ with -O1: 

[  149s] xc_dom_x86.c: In function 'meminit_hvm':
[  149s] xc_dom_x86.c:1262: error: 'rc' may be used uninitialized in this 
function
[  149s] make[4]: *** [xc_dom_x86.o] Error 1


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel