[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vm_event: make sure the domain is paused in key domctls

On Thu, Jan 28, 2016 at 6:52 AM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> wrote:
This patch pauses the domain for all writes through the 'ad'
pointer in monitor_domctl(), defers a domain_unpause() call until
after the CRs are updated for the MONITOR_EVENT_WRITE_CTRLREG
case, and makes sure that the domain is paused for both vm_event
enable and disable cases in vm_event_domctl().
Thanks go to Andrew Cooper for his review and suggestions.

For vm_event_enable the domain is already paused by libxc before the domctl is issued. I don't see a problem in doing another pause in Xen, but given we have XSA-99, just doing this pause in Xen would not be enough. So is it really necessary/fixes anything?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.