[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 19/21] arm/acpi: Initialize serial port from ACPI SPCR table
On 2016/1/25 23:05, Jan Beulich wrote: >>>> On 23.01.16 at 10:20, <zhaoshenglong@xxxxxxxxxx> wrote: >> --- a/xen/include/acpi/actbl2.h >> +++ b/xen/include/acpi/actbl2.h >> @@ -815,6 +815,15 @@ struct acpi_table_spcr { >> >> #define ACPI_SPCR_DO_NOT_DISABLE (1) >> >> +/* SPCR Interface type */ >> +#define ACPI_SPCR_TYPE_16550 0 >> +#define ACPI_SPCR_TYPE_16550_SUB 0x1 >> +#define ACPI_SPCR_TYPE_PL011 0x3 >> +#define ACPI_SPCR_TYPE_SBSA_32 0xd >> +#define ACPI_SPCR_TYPE_SBSA 0xe >> +#define ACPI_SPCR_TYPE_DCC 0xf >> +#define ACPI_SPCR_TYPE_BCM2835 0x10 > > It seems very likely to me that this part of the change actually would > have a Linux counterpart, in which case it should be submitted as such. > I checked it with Linux master. Those interface types are shared with DGB2 table. But Linux master only adds ACPI_DBG2_16550_COMPATIBLE and ACPI_DBG2_16550_SUBSET, doesn't have other types. And actually we only need the interface type not the DBG2 table. Yes, it could port commit [1] first then add other types. Is that fine? [1]4e2f9c278ad84196991fcf6f6646a3e15967fe90 Thanks, -- Shannon _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |