[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v6 09/18] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty()
On 01/26/2016 10:27 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 26, 2016 at 03:04:39PM +0800, Wen Congyang wrote: >> On 01/26/2016 02:59 AM, Konrad Rzeszutek Wilk wrote: >>> On Wed, Dec 30, 2015 at 10:28:59AM +0800, Wen Congyang wrote: >>>> Secondary vm is running in colo mode, we need to send >>>> secondary vm's dirty page information to master at checkpoint, >>> >>> In previous patch you called it primary, so perhaps: >>> s/master/primary/ ? >>> >>>> so we have to enable qemu logdirty on secondary. >>>> >>>> libxl__domain_suspend_common_switch_qemu_logdirty() is to enable >>>> qemu logdirty. But it uses domain_save_state, and calls >>> >>> s/domain_save_state/libxl__domain_save_state/ >>>> libxl__xc_domain_saverestore_async_callback_done() >>>> before exits. This can not be used for secondary vm. >>>> >>>> Update libxl__domain_suspend_common_switch_qemu_logdirty() to >>>> introduce a new API libxl__domain_common_switch_qemu_logdirty(). >>>> This API only uses libxl__logdirty_switch, and calls >>>> lds->callback before exits. >>> >>> One question - that perhaps had been part of the review earlier >>> (if so it may be good to include this in the description >>> so I don't ask silly questions): >>> >>> Why add this extra API? You could squash >>> libxl__domain_suspend_common_switch_qemu_logdirty >>> and libxl__domain_common_switch_qemu_logdirty code together >>> and call it libxl_domain_common_and_suspend_common_switch_qemu_logdirty >>> (ok, just kidding on the name). But - why not have one function >>> instead of splitting the functionality in two? >> >> Do you mean that auto switch qemu logdirty when suspend the guest? > > Squash the two functions - libxl__domain_common_switch_qemu_logdirty and > libxl__domain_suspend_common_switch_qemu_logdirty together? IIRC, no codes need such API now. Thanks Wen Congyang > > > . > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |