Re: [Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote:
> Describe what the four (or more in the future) arguments
> are for.

I'd say that a code comment on the definition would be sufficient here, but
I'll defer to Ian J as author of this code.

> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> Âtools/libxl/libxl_save_callout.c | 11 ++++++++++-
> Â1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_save_callout.c
> b/tools/libxl/libxl_save_callout.c
> index 3af99af..45b9727 100644
> --- a/tools/libxl/libxl_save_callout.c
> +++ b/tools/libxl/libxl_save_callout.c
> @@ -119,13 +119,22 @@ void
> libxl__save_helper_init(libxl__save_helper_state *shs)
> Â
> Â/*----- helper execution -----*/
> Â
> +/*
> + * Both save and restore share four parameters:
> + * 1) Path to libxl-save-helper.
> + * 2) --[restore|save]-domain.
> + * 3) stream file descriptor.
> + * n) save/restore specific parameters.
> + * 4) A \0 at the end.
> + */
> +#define HELPER_NR_ARGS 4
> Âstatic void run_helper(libxl__egc *egc, libxl__save_helper_state *shs,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂconst char *mode_arg, int stream_fd,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂconst int *preserve_fds, int num_preserve_fds,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂconst unsigned long *argnums, int num_argnums)
> Â{
> ÂÂÂÂÂSTATE_AO_GC(shs->ao);
> -ÂÂÂÂconst char *args[4 + num_argnums];
> +ÂÂÂÂconst char *args[HELPER_NR_ARGS + num_argnums];
> ÂÂÂÂÂconst char **arg = args;
> ÂÂÂÂÂint i, rc;
> Â

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel