Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

[Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>]

On 01/26/2016 02:48 PM, Wen Congyang wrote:
> On 01/26/2016 02:45 PM, Yang Hongyang wrote:
> > ditto
> >
> > Reviewed-by: Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
> The newest version is v5, and this series is in the staging now.
Sorry for the noise...I saw the series too late, please ignore my
comments...

> Thanks for your review.
> Wen Congyang
>
> > On 01/08/2016 02:38 PM, Wen Congyang wrote:
> > > Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> > > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > > ---
> > >    tools/libxc/xc_sr_save.c | 4 +++-
> > >    1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> > > index e532168..e4ba560 100644
> > > --- a/tools/libxc/xc_sr_save.c
> > > +++ b/tools/libxc/xc_sr_save.c
> > > @@ -791,7 +791,9 @@ static int save(struct xc_sr_context *ctx, uint16_t 
> > > guest_type)
> > >                if ( rc )
> > >                    goto err;
> > >
> > > -            ctx->save.callbacks->postcopy(ctx->save.callbacks->data);
> > > +            rc = ctx->save.callbacks->postcopy(ctx->save.callbacks->data);
> > > +            if ( rc <= 0 )
> > > +                goto err;
> > >
> > >                rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks->data);
> > >                if ( rc <= 0 )
--
Thanks,
Yang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel