[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 00/18] Prerequisite patches for COLO

On Mon, Jan 25, 2016 at 12:12:48PM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Dec 30, 2015 at 10:28:50AM +0800, Wen Congyang wrote:
> > This patchset is Prerequisite for COLO feature. Refer to:
> > http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping
> > 
> > It was based on the following series:
> > http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02881.html
> You wouldn't have this in a git tree? It is a bit hard to apply on the latest
> staging. Or could you say on what branch/git commit it was based on?

I looked at the patches and they just minor tweaking from my perspective.

I think when you get to reposting it with my review comments you may want
to have in the cover letter a list of all the patches and which
ones have been reviewed and acked. That way the maintainers can zoom in
on the ones that still need some tweaking/review.

And also if possible - do include a git tree. At certain point in the patchset
you had moved some functions, did a bit of renaming and it was hard to reference
to the original staging tree to see the code around the functions.

Having a git tree would allow the reviewers to nicely git checkout at certain
points and be able to see the code. Perhaps this is me - and if getting
a git tree is quite difficult - then don't sweat over it.

Thank you!
> Thanks.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.