[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v5 COLOPre 07/18] migration/save: pass checkpointed_stream from libxl to libxc
On Thu, Dec 17, 2015 at 03:48:11PM +0800, Wen Congyang wrote: > From: Yang Hongyang <hongyang.yang@xxxxxxxxxxxx> > > Pass checkpointed_stream from libxl to libxc. > It won't affact legacy migration because legacy migration > won't use this param. Ah, that is why you wanted to keep it as in 'int' in the struct domain_create. You may want to update patch #6 to mention that you need it to pass it on libxc. ..snip.. > @@ -834,7 +836,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t > dom, > ctx.save.callbacks = callbacks; > ctx.save.live = !!(flags & XCFLAGS_LIVE); > ctx.save.debug = !!(flags & XCFLAGS_DEBUG); > - ctx.save.checkpointed = !!(flags & XCFLAGS_CHECKPOINTED); > + ctx.save.checkpointed = checkpointed_stream; Should you have an check to make sure they are the right enums? /* If altering migration_stream update this assert too. */ assert(checkpointed_stream == LIBXL_CHECKPOINTED_STREAM_NONE || checkpointed_stream == LIBXL_CHECKPOINTED_STREAM_REMUS); .. snip.. > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 3ef11aa..9aa94be 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -228,6 +228,7 @@ libxl_hdtype = Enumeration("hdtype", [ > (2, "AHCI"), > ], init_val = "LIBXL_HDTYPE_IDE") > > +# Consistent with the values defined for migration_stream s/stream/stream./ > libxl_checkpointed_stream = Enumeration("checkpointed_stream", [ > (0, "NONE"), > (1, "REMUS"), > -- > 2.5.0 > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |