Re: [Xen-devel] [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-01-22 at 12:12 -0500, Boris Ostrovsky wrote:
> On 01/15/2016 08:22 AM, Ian Campbell wrote:
> > libxenevtchn will provide a stable API and ABI for accessing the
> > evtchn device.
> 
> I think this patch breaks the build:
> 
> root@ovs101> gccÂÂ-O1 -fno-omit-frame-pointer -m64 -gÂ
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypesÂ
> -Wdeclaration-after-statement -Wno-unused-but-set-variableÂÂÂ-O0 -g3Â
> -D__XEN_TOOLS__ -MMD -MF .core.o.d -D_LARGEFILE_SOURCEÂ
> -D_LARGEFILE64_SOURCE -fno-optimize-sibling-callsÂÂ-WerrorÂ
> -Wmissing-prototypes -I./includeÂ
> -I/root/xen/tools/libs/evtchn/../../../tools/includeÂ
> -I/root/xen/tools/libs/evtchn/../../../tools/libs/toollog/includeÂ
> -I/root/xen/tools/libs/evtchn/../../../tools/includeÂÂ-c -o core.o core.c
> In file included from private.h:5,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfrom core.c:19:
> ./include/xenevtchn.h:36: error: redefinition of typedef âxentoollog_loggerâ
> /root/xen/tools/libs/evtchn/../../../tools/libs/toollog/include/xentoollog.h:44:
> Â
> note: previous declaration of âxentoollog_loggerâ was here

Hrm, it seems to be OK by the end of the series, in that it built for me
before push and has passed smoke-test. So I may have introduced a bisection
hazard (sorry) but it's too late to fix that unfortunately.

Various of the tools/libs/*/include/*.h have a

    /* Callers who don't care don't need to #include <xentoollog.h> */
    typedef struct xentoollog_logger xentoollog_logger;

but since that typedef matches in all cases I think it is allowed to be
repeated like this, isn't it?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel