[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure
On 22/01/16 14:22, Ian Campbell wrote: > On Fri, 2016-01-22 at 14:16 +0000, Malcolm Crossley wrote: >> On 22/01/16 13:54, Ian Campbell wrote: >>> On Fri, 2016-01-22 at 13:41 +0000, Malcolm Crossley wrote: >>>> >>>> Changes since v5: >>>> - Fix compilation on ARM >>> >>> This was the removal of some spurious "&", I think? >> >> Yeah, I forgot to keep the macro's in sync. ARM also needed the >> xen/percpu.h header file to be >> explictly included into spinlock.h. >> >>> >>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> >>> >>> Thanks for catching this! >> >> Sorry for not build testing before on ARM. > > No problem, some people never remember at all, so v5 isn't too bad ;-) > >> Building the hypervisor itself using a prebuilt linaro >> toolchain is actually very easy (no chroot required). > > Indeed. > >> Do you think it's worth documenting this? So that at least hypervisor >> build failures are caught. > > I think it's covered by > http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions#Cross_Compiling Yeah that section covers it. I came across the toolstack page first and didn't check the third link down in google :) https://www.google.co.uk/search?q=xen+cross+compilation Maybe there should be comment in the toolstack page linking back to the simpler hypervisor only steps :) > > or do you mean something more? > > Ian. > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |