Re: [Xen-devel] [PATCH v3 1/1] xen: sched: convert RTDS from time to event driven model

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

Hi guys,

On Thu, 2016-01-21 at 23:06 -0500, Tianyang Chen wrote:
> Budget replenishment and enforcement are separated by adding
> a replenishment timer, which fires at the next most imminent
> release time of all runnable vcpus.
> 
> [...]
>
I started to look at this patch, and for doing that, I tried to apply
it to current staging branch, and I got this:

Hunk #4 FAILED at 169.
Hunk #5 succeeded at 222 (offset -2 lines).
Hunk #6 succeeded at 242 (offset -2 lines).
Hunk #7 FAILED at 316.
Hunk #8 succeeded at 327 (offset -2 lines).
Hunk #9 succeeded at 343 with fuzz 2 (offset -2 lines).
Hunk #14 FAILED at 655.
Hunk #15 succeeded at 853 (offset -7 lines).
Hunk #16 succeeded at 871 (offset -7 lines).
Hunk #17 succeeded at 896 (offset -7 lines).
Hunk #18 succeeded at 911 (offset -7 lines).
Hunk #19 succeeded at 1058 (offset -7 lines).
Hunk #20 FAILED at 1102.
Hunk #21 succeeded at 1197 with fuzz 1 (offset 1 line).
4 out of 21 hunks FAILED

Looks like the patch is based on a pretty old source base (it's missing
one cleanup I've made to all schedulers' files', including sched_rt.c,
a few months ago).

When you send a patch, you usually do that on the most updated source
base or, if something prevents doing that, you should clearly specify
in the cover letter on top of what the patch should be applied.

So, please, refresh the patch.

> A new runningq has been added to keep track of all vcpus that
> are on pcpus.
> 
I've been looking at the v2, and at the discussion between you and
Meng. I'm not convinced that we really need to add this runningq thing.
So, if you don't mind, I''l go back to v2, and comment on it.

If, during the review, it turns out that we need something like this,
I'll come here again.

In the meantime, do the refresh, but do not resend. You can do that
after having seen my comments.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel