[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()
On 21/01/2016 18:01, Stefano Stabellini wrote: > - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg > 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n", > - j, > ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), > - regs->offset, > xen_pt_emu_reg_grps[i].grp_type, > - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc); > + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err); > + if (err) { > + error_append_hint(&err, "Failed to initialize %d/%zu" > + " reg 0x%x in grp_type = 0x%x (%d/%zu)", > + j, > ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), Coverity noticed a preexisting problem here. emu_regs is a pointer, thus ARRAY_SIZE doesn't return what you expect. Paolo > + regs->offset, > xen_pt_emu_reg_grps[i].grp_type, > + i, ARRAY_SIZE(xen_pt_emu_reg_grps)); > + error_propagate(errp, err); _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |