Re: [Xen-devel] [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("Re: [PATCH v2 5/5] libxl: Add explicit cast to 
libxl_psr_cat_set_cbm"):
> On Tue, 2016-01-19 at 14:21 +0000, Ian Campbell wrote:
> > libxl_shutdown_reason has the same issues, libxl_tsc_mode also might,
> > as might libxl_timer_mode. I'm not sure if there are others. 
> >
> (FTR) libxl_scheduler too, probably?

Quite possibly.  Hrm.

I see that for shutdown_reason Ian C did this deliberately in "libxl:
Remove xen/sched.h from public interface".

I am really not a fan of this approach.  I don't remember what I said
about that at the time.  The result is multiple enums with the same
values in that need to be kept in step.

However, I'm not sure I can persuade everyone to agree on an
alternative.  At the very least we should document the rules in
CODING_STYLE.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel