Re: [Xen-devel] [PATCH XEN v8 20/29] tools/libs/gnttab: Extensive updates to API documentation.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jan 15, 2016 at 01:22:59PM +0000, Ian Campbell wrote:
> In particular around error handling, behaviour on fork and the unmap
> notification mechanism.
> 
> Behaviour of xengnttab_map_*grant_refs and xengntshr_share_pages on
> partial failure has been confirmed/inferred (by inspection) on Linux
> and Mini-os (the only two known implementations. Likewise the
> behaviour of the notification mechanism has been confirmed/inferred
> (by inspection) of the Linux implementation (currently the only
> implementation) and libvchan (primary known user).
> 
> These updates are not folded into "tools: Refactor
> /dev/xen/gnt{dev,shr} wrappers into libxengnttab." to try and reduce
> the amount of non-movement changes in that patch.
> 
> While I'm not convinced by javadoc/doxygen cause the existing comments
> which appear to use that syntax to have the appropriate /** marker.
> 
> Also fix a typo in a code comment.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Reviewed-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Since Daniel and Ian have done in depth review of this so I only skim it
this time. It looks sensible to me:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

(one typo below)

[...]
> + *
> + * NOTE: this protocol is intended to allow for better error behaviour
> + * and recovery between two cooperating peers. It does not cover the
> + * case of a malivious peer who may continue to hold resources open.

"malicious"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel