Re: [Xen-devel] [PATCH v3 14/15] tools: don't stop xenstore domain when stopping dom0

[Juergen Gross <jgross@xxxxxxxx>]

On 15/01/16 17:12, Ian Campbell wrote:
> On Fri, 2016-01-08 at 14:08 +0100, Juergen Gross wrote:
>> +# get xenstore domain id (or 0 if no xenstore domain)
>> +get_xsdomid()
>> +{
>> +    XS_DOMID=`${bindir}/xenstore-read /tool/xenstored/domid 2>/dev/null`
>> +    if test $? -ne 0; then
>> +        XS_DOMID=0
>> +    fi
> 
> In principal this could be:
> +    XS_DOMID=`${bindir}/xenstore-read /tool/xenstored/domid 2>/dev/null || 
> echo 0`
> 
> But I'm far from convinced that is an improvement.

I think I'll leave it as before.

> 
>> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
>> index f9933cb..29f9d19 100644
>> --- a/tools/libxl/xl_cmdimpl.c
>> +++ b/tools/libxl/xl_cmdimpl.c
>> @@ -4856,15 +4856,17 @@ static int main_shutdown_or_reboot(int do_reboot,
>> int argc, char **argv)
>>          if (wait_for_it)
>>              deathws = calloc(nb_domain, sizeof(*deathws));
>>  
>> +        wait_for_it = 0;
> 
> Please can we avoid reusing the boolean flag used for argument handling as
> a counter.
> 
> I think you will need to introduce a new nrdeathws.

Okay, will do.


Thanks,

Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel