Re: [Xen-devel] [PATCH v2 3/3] xenstat: handle more than 1024 domains

[Juergen Gross <jgross@xxxxxxxx>]

On 15/01/16 16:35, Ian Campbell wrote:
> On Mon, 2016-01-04 at 16:38 +0000, Wei Liu wrote:
>> On Mon, Jan 04, 2016 at 03:55:53PM +0100, Juergen Gross wrote:
> 
>>> -   dominfo = get_domain_ids(node->handle->xc_handle, &num_doms);
>>> -   if (dominfo == NULL)
>>> -           return;
>>> +   for (;;) {
>>> +           num_doms = xc_domain_getinfolist(node->handle-
>>>> xc_handle, next_domid, 1024, dominfo);
>>
>> Some lines have exceeded 80 columns. Not really your fault so no need to
>> resend.
> 
> If not the person adding the lines as apparently fresh code then whose
> fault is it?

Clearly mine. I just finished reading Wei's comment after the
"Reviewed-by" tag. Sorry for that.

> These ones seem pretty trivial to wrap correctly so I think I would prefer
> to see them done.

Sure.

> I'll apply #1 and #2 in a moment and expect a resend of this one. Sorry for
> the delay both in applying and commenting, looks like these got buried in
> the post vacation pile.

I thought so. Thanks for doing now.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel