Re: [Xen-devel] [PATCH RFC] xen/Kconfig: Use olddefconfig not silentoldconfig to update .config

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-01-15 at 14:48 +0000, Ian Campbell wrote:
> RFC RFC RFC RFC RFC RFC RFC RFC RFC RFC RFC
> BECAUSE THIS BREAKS CLEAN BUILDS WITH:
> In file included from <command-line>:0:0:
> /local/scratch/ianc/devel/arm/xen.git/xen/include/xen/config.h:10:32:
> fatal error: generated/autoconf.h: No such file or directory
> Â#include <generated/autoconf.h>
> 
> I'm not sure why given the descriptions of olddefconfig and
> silentoldconfig below.

xen/tools/kconfig/Makefile holds the answer...

    silentoldconfig: $(obj)/conf
            $(Q)mkdir -p include/config include/generated
            $< $(silent) --$@ $(Kconfig)

vs for olddefconfig (which is in $(simple-targets)):

    $(simple-targets): $(obj)/conf
            $< $(silent) --$@ $(Kconfig)

However the (seemingly) obvious answer of:

    diff --git a/xen/Makefile b/xen/Makefile
    index f8f3bb4..2422ba8 100644
    --- a/xen/Makefile
    +++ b/xen/Makefile
    @@ -239,6 +239,7 @@ $(kconfig):
    ÂÂÂÂÂÂÂÂ$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(XEN_TARGET_ARCH) $@
    Â
    Âinclude/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG)
    +ÂÂÂÂÂÂÂ$(Q)mkdir -p include/config include/generated
    ÂÂÂÂÂÂÂÂ$(Q)$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(XEN_TARGET_ARCH) olddefconfig
    Â
    Â# Allow people to just run `make` as before and not force them to configure

Doesn't help, so I suppose there must be an actual semantic difference in
$(obj)/conf for these two options.

So I'm not sure what to do now.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel