Re: [Xen-devel] [PATCH v1] xen/arm: Add r1p12 to the list of supported Cadence UARTs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-01-15 at 15:36 +0100, Edgar E. Iglesias wrote:
> On Fri, Jan 15, 2016 at 01:46:05PM +0000, Ian Campbell wrote:
> > On Fri, 2016-01-15 at 14:30 +0100, Edgar E. Iglesias wrote:
> > > On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote:
> > > > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote:
> > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>
> > > > 
> > > > Where are the bindings forÂcdns,uart-r1p12 defined? I don't see it
> > > > mentioned in the
> > > > Documentation/devicetree/bindings/serial/cdns,uart.txt
> > > > in
> > > > mainline Linux.
> > > 
> > > Hi Ian,
> > > 
> > > The bindings are currently in our queue:
> > > https://github.com/Xilinx/linux-
> > > xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart
> > > .txt
> > 
> > Great, thanks.
> > > Â
> > > > Does the driver need to differ at all compared with what is needed
> > > > for
> > > > r1p8? Normally if there is no (practical/visible) difference then
> > > > in
> > > > DT-
> > > > world there is no need for a new compatible string, since the
> > > > device is
> > > > still compatible.
> > > > 
> > > > If there are differences in the h/w but they are not relevant to
> > > > our
> > > > particular driven then please say so in the commit log.
> > > 
> > > Right, there are SW visible differences (the Linux driver uses them)
> > > but
> > > none affecting XEN. I'll note that in the commit message.
> > 
> > If you want to just supply some words here I'll fold them in upon
> > commit.
> > Or feel free to send a v2 if you prefer.
> 
> Thanks Ian, I've inlined something here.
> BTW, what is the policy for getting patches into -stable?

Please seeÂhttp://wiki.xen.org/wiki/Xen_Maintenance_ReleasesÂand the
MAINTAIENRS file in the stable branches.

TL;DR: I think this is fine and I have added to my list of things to
backport.

> It would be great if this patch could be taken in to have
> XEN 4.6.x work out of the box on ZynqMPSoC with updated
> DTBs.
> 
> Best regards,
> Edgar
> 
> New commit message:
> xen/arm: Add r1p12 to the list of supported Cadence UARTs
> 
> Add r1p12 to the list of supported Cadence UARTs. XEN only
> uses the subset of features available in r1p8, so we don't
> need to differentiate between r1p8 and r1p12 yet.
> 
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

<pedant>It's spelled "Xen" or "xen", not "XEN"</pedant>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel