Re: [Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.16 at 18:23, <roger.pau@xxxxxxxxxx> wrote:
> El 13/01/16 a les 17.29, Jan Beulich ha escrit:
>>>>> On 13.01.16 at 13:32, <roger.pau@xxxxxxxxxx> wrote:
>>> The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the
>>> initial state, which is called from the toolstack during domain creation.
>> 
>> But the comment that you remove says explicitly that this isn't a
>> requirement.
> 
> Previous to my HVMlite series that was true, and HVM guests were started
> without setting any explicit CPU state (in fact we placed that horrible
> jmp at 0x0, because the IP was by default set to 0x0). This is no longer
> true, and now HVM guests require that a proper CPU context is loaded
> before starting. I believe this is better, and this change helps enforce
> this policy.

Well, that's fine, but the patch description then needs to reflect
this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel